{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":26850443,"defaultBranch":"master","name":"rust-clippy","ownerLogin":"rust-lang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-11-19T07:49:21.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5430905?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714737342.0","currentOid":""},"activityList":{"items":[{"before":"380c11b8f4982ea787940e433c95db03aa7048fd","after":"b1b5fee74e6b210cdacb61f373a5cbeae43290b2","ref":"refs/heads/gh-pages","pushedAt":"2024-06-08T09:54:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Manishearth","name":"Manish Goregaokar","path":"/Manishearth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1617736?s=80&v=4"},"commit":{"message":"Automatic deploy to GitHub Pages: 48686adf48e2017feb9da59fbb606eb3c57dfe76","shortMessageHtmlLink":"Automatic deploy to GitHub Pages: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/rust-lang/rust-clippy/commit/48686adf48e2017feb9da59fbb606eb3c57dfe76/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/commit/48686adf48e2017feb9da59fbb606eb3c57dfe76\"><tt>48686ad</tt></a>"}},{"before":"0ea88b90d8fbcb140314db4e689f8c78cc428907","after":"48686adf48e2017feb9da59fbb606eb3c57dfe76","ref":"refs/heads/master","pushedAt":"2024-06-08T09:53:10.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12805 - Alexendoo:blocks-in-conditions-closures, r=dswij\n\nDon't lint blocks in closures for blocks_in_conditions\n\nSeemed like an outlier for the lint which generally caught only the syntactically confusing cases, it lints blocks in closures but excludes closures passed to iterator methods, this changes it to ignore closures in general\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2298468913\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12805\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12805/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12805\">#12805</a> - Alexendoo:blocks-in-conditions-closures, r=dswij"}},{"before":"0ea88b90d8fbcb140314db4e689f8c78cc428907","after":"48686adf48e2017feb9da59fbb606eb3c57dfe76","ref":"refs/heads/auto","pushedAt":"2024-06-08T09:45:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12805 - Alexendoo:blocks-in-conditions-closures, r=dswij\n\nDon't lint blocks in closures for blocks_in_conditions\n\nSeemed like an outlier for the lint which generally caught only the syntactically confusing cases, it lints blocks in closures but excludes closures passed to iterator methods, this changes it to ignore closures in general\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2298468913\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12805\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12805/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12805\">#12805</a> - Alexendoo:blocks-in-conditions-closures, r=dswij"}},{"before":"d553ebef573712d66470fa85e08d97a67375c243","after":"0ea88b90d8fbcb140314db4e689f8c78cc428907","ref":"refs/heads/master","pushedAt":"2024-06-07T23:02:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12900 - Alexendoo:no-lazy-static, r=llogiq\n\nRemove `lazy_static` mention\n\nI planned to replace any mention with `LazyLock` but I think `thread_local` is more appropriate here - `const`s that aren't `Sync` wouldn't be able to go in a `lazy_static`/`static LazyLock` either\n\nAlso removed a test file that was mostly commented out so wasn't testing anything\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2340304789\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12900\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12900/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12900\">#12900</a> - Alexendoo:no-lazy-static, r=llogiq"}},{"before":"d553ebef573712d66470fa85e08d97a67375c243","after":"0ea88b90d8fbcb140314db4e689f8c78cc428907","ref":"refs/heads/auto","pushedAt":"2024-06-07T22:54:03.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12900 - Alexendoo:no-lazy-static, r=llogiq\n\nRemove `lazy_static` mention\n\nI planned to replace any mention with `LazyLock` but I think `thread_local` is more appropriate here - `const`s that aren't `Sync` wouldn't be able to go in a `lazy_static`/`static LazyLock` either\n\nAlso removed a test file that was mostly commented out so wasn't testing anything\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2340304789\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12900\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12900/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12900\">#12900</a> - Alexendoo:no-lazy-static, r=llogiq"}},{"before":"1e407642e82e038f0d2f81aa71271649af23b097","after":"d553ebef573712d66470fa85e08d97a67375c243","ref":"refs/heads/master","pushedAt":"2024-06-07T21:37:42.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12851 - samueltardieu:issue12846, r=y21\n\nAdd required parentheses around method receiver\n\nFix #12846\n\nchangelog: [`needless_bool`]: Add missing parentheses around method receiver","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317110600\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12851\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12851/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12851\">#12851</a> - samueltardieu:issue12846, r=y21"}},{"before":"1e407642e82e038f0d2f81aa71271649af23b097","after":"d553ebef573712d66470fa85e08d97a67375c243","ref":"refs/heads/auto","pushedAt":"2024-06-07T21:27:47.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12851 - samueltardieu:issue12846, r=y21\n\nAdd required parentheses around method receiver\n\nFix #12846\n\nchangelog: [`needless_bool`]: Add missing parentheses around method receiver","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317110600\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12851\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12851/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12851\">#12851</a> - samueltardieu:issue12846, r=y21"}},{"before":"336046c5e268b08dca338354afe24465c1f67df3","after":"1e407642e82e038f0d2f81aa71271649af23b097","ref":"refs/heads/master","pushedAt":"2024-06-07T16:48:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12901 - J-ZhengLi:test_case, r=Manishearth\n\n[`match_same_arms`]: add a test case with lifetimes\n\nas reminded by: #8919\n\n---\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2340775542\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12901\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12901/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12901\">#12901</a> - J-ZhengLi:test_case, r=Manishearth"}},{"before":"336046c5e268b08dca338354afe24465c1f67df3","after":"1e407642e82e038f0d2f81aa71271649af23b097","ref":"refs/heads/auto","pushedAt":"2024-06-07T16:38:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12901 - J-ZhengLi:test_case, r=Manishearth\n\n[`match_same_arms`]: add a test case with lifetimes\n\nas reminded by: #8919\n\n---\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2340775542\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12901\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12901/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12901\">#12901</a> - J-ZhengLi:test_case, r=Manishearth"}},{"before":"404affb7bdeee0694bc2b9300c4e7ef53f109a60","after":"380c11b8f4982ea787940e433c95db03aa7048fd","ref":"refs/heads/gh-pages","pushedAt":"2024-06-07T10:12:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Manishearth","name":"Manish Goregaokar","path":"/Manishearth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1617736?s=80&v=4"},"commit":{"message":"Automatic deploy to GitHub Pages: 336046c5e268b08dca338354afe24465c1f67df3","shortMessageHtmlLink":"Automatic deploy to GitHub Pages: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/rust-lang/rust-clippy/commit/336046c5e268b08dca338354afe24465c1f67df3/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/commit/336046c5e268b08dca338354afe24465c1f67df3\"><tt>336046c</tt></a>"}},{"before":"f990ea155e1c6b338048db3fd2841c686cadc352","after":"336046c5e268b08dca338354afe24465c1f67df3","ref":"refs/heads/master","pushedAt":"2024-06-07T10:10:17.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12889 - xFrednet:changelog-1-79, r=flip1995,dswij\n\nChangelog for Clippy 1.79 🎓\n\nTwo cat ears from waffle,\nA tail and a dress,\nThat's our Jyn,\nThe magnificent cat\n\n~ =^.^=\n\n---\n\n### The cat of this release is: *Jyn* submitted by `@jyn514:`\n\n<img height=600 src=\"https://github.com/rust-lang/rust-clippy/assets/17087237/2f902dea-9ad5-4ad2-b281-1f152b7ad7c7\" alt=\"The cat(s) of this Clippy release\" />\n\nCats for the next release can be nominated in the comments :D\n\n---\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2335720151\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12889\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12889/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12889\">#12889</a> - xFrednet:changelog-1-79, r=flip1995,dswij"}},{"before":"f990ea155e1c6b338048db3fd2841c686cadc352","after":"336046c5e268b08dca338354afe24465c1f67df3","ref":"refs/heads/auto","pushedAt":"2024-06-07T10:02:33.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12889 - xFrednet:changelog-1-79, r=flip1995,dswij\n\nChangelog for Clippy 1.79 🎓\n\nTwo cat ears from waffle,\nA tail and a dress,\nThat's our Jyn,\nThe magnificent cat\n\n~ =^.^=\n\n---\n\n### The cat of this release is: *Jyn* submitted by `@jyn514:`\n\n<img height=600 src=\"https://github.com/rust-lang/rust-clippy/assets/17087237/2f902dea-9ad5-4ad2-b281-1f152b7ad7c7\" alt=\"The cat(s) of this Clippy release\" />\n\nCats for the next release can be nominated in the comments :D\n\n---\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2335720151\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12889\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12889/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12889\">#12889</a> - xFrednet:changelog-1-79, r=flip1995,dswij"}},{"before":"0f87a81882f1a110b6d11c18a2223723984d10dd","after":"f990ea155e1c6b338048db3fd2841c686cadc352","ref":"refs/heads/master","pushedAt":"2024-06-07T10:01:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12844 - Alexendoo:to-string-in-format-args, r=dswij\n\nFix `to_string_in_format_args` with macro call receiver\n\nFixes part of #12837\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2316130036\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12844\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12844/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12844\">#12844</a> - Alexendoo:to-string-in-format-args, r=dswij"}},{"before":"0f87a81882f1a110b6d11c18a2223723984d10dd","after":"f990ea155e1c6b338048db3fd2841c686cadc352","ref":"refs/heads/auto","pushedAt":"2024-06-07T09:52:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12844 - Alexendoo:to-string-in-format-args, r=dswij\n\nFix `to_string_in_format_args` with macro call receiver\n\nFixes part of #12837\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2316130036\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12844\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12844/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12844\">#12844</a> - Alexendoo:to-string-in-format-args, r=dswij"}},{"before":"0b441d5ac5934eecb4254f71a8557cf9cb6b882e","after":"0f87a81882f1a110b6d11c18a2223723984d10dd","ref":"refs/heads/master","pushedAt":"2024-06-07T09:51:14.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12822 - Alexendoo:for-each-expr, r=dswij\n\nMake `for_each_expr` visit closures by default, rename the old version `for_each_expr_without_closures`\n\nA lot of the time `for_each_expr` is picked when closures should be visited so I think it makes sense for this to be the default with the alternative available for when you don't need to visit them.\n\nThe first commit renames `for_each_expr` to `for_each_expr_without_closures` and `for_each_expr_with_closures` to `for_each_expr`\n\nThe second commit switches a few uses that I caught over to include closures to fix a few bugs\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2304656467\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12822\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12822/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12822\">#12822</a> - Alexendoo:for-each-expr, r=dswij"}},{"before":"0b441d5ac5934eecb4254f71a8557cf9cb6b882e","after":"0f87a81882f1a110b6d11c18a2223723984d10dd","ref":"refs/heads/auto","pushedAt":"2024-06-07T09:42:39.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12822 - Alexendoo:for-each-expr, r=dswij\n\nMake `for_each_expr` visit closures by default, rename the old version `for_each_expr_without_closures`\n\nA lot of the time `for_each_expr` is picked when closures should be visited so I think it makes sense for this to be the default with the alternative available for when you don't need to visit them.\n\nThe first commit renames `for_each_expr` to `for_each_expr_without_closures` and `for_each_expr_with_closures` to `for_each_expr`\n\nThe second commit switches a few uses that I caught over to include closures to fix a few bugs\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2304656467\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12822\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12822/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12822\">#12822</a> - Alexendoo:for-each-expr, r=dswij"}},{"before":"d9ae9367ba7814a380b6501c3ca67dadd3d72641","after":"0b441d5ac5934eecb4254f71a8557cf9cb6b882e","ref":"refs/heads/master","pushedAt":"2024-06-07T09:41:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12877 - y21:const_host_ice, r=dswij\n\nHandle const effects inherited from parent correctly in `type_certainty`\n\nThis fixes a (debug) ICE in `type_certainty` that happened in the [k256 crate]. (I'm sure you can also specifically construct an edge test case that will run into type_certainty false positives visible outside of debug builds from this bug)\n\n<details>\n<summary>Minimal ICE repro</summary>\n\n```rs\nuse std::ops::Add;\nAdd::add(1_i32, 1).add(i32::MIN);\n```\n</details>\n\nThe subtraction here overflowed:\nhttps://github.com/rust-lang/rust-clippy/blob/436675b4772049a0ff535bd46d944689c90ed750/clippy_utils/src/ty/type_certainty/mod.rs#L209\n\n... when we have something like `Add::add` where `add` fn has 0 generic params but the `host_effect_index` is `Some(2)` (inherited from the parent generics, the const trait `Add`), and we end up executing `0 - 1`.\n\n(Even if the own generics weren't empty and we didn't overflow, this would still be wrong because it would assume that a trait method with 1 generic parameter didn't have any generics).\n\nSo, *only* exclude the \"host\" generic parameter if it's actually bound by the own generics\n\nchangelog: none\n\n[k256 crate]: https://github.com/RustCrypto/elliptic-curves/tree/master/k256","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2329311000\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12877\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12877/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12877\">#12877</a> - y21:const_host_ice, r=dswij"}},{"before":"d9ae9367ba7814a380b6501c3ca67dadd3d72641","after":"0b441d5ac5934eecb4254f71a8557cf9cb6b882e","ref":"refs/heads/auto","pushedAt":"2024-06-07T09:33:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12877 - y21:const_host_ice, r=dswij\n\nHandle const effects inherited from parent correctly in `type_certainty`\n\nThis fixes a (debug) ICE in `type_certainty` that happened in the [k256 crate]. (I'm sure you can also specifically construct an edge test case that will run into type_certainty false positives visible outside of debug builds from this bug)\n\n<details>\n<summary>Minimal ICE repro</summary>\n\n```rs\nuse std::ops::Add;\nAdd::add(1_i32, 1).add(i32::MIN);\n```\n</details>\n\nThe subtraction here overflowed:\nhttps://github.com/rust-lang/rust-clippy/blob/436675b4772049a0ff535bd46d944689c90ed750/clippy_utils/src/ty/type_certainty/mod.rs#L209\n\n... when we have something like `Add::add` where `add` fn has 0 generic params but the `host_effect_index` is `Some(2)` (inherited from the parent generics, the const trait `Add`), and we end up executing `0 - 1`.\n\n(Even if the own generics weren't empty and we didn't overflow, this would still be wrong because it would assume that a trait method with 1 generic parameter didn't have any generics).\n\nSo, *only* exclude the \"host\" generic parameter if it's actually bound by the own generics\n\nchangelog: none\n\n[k256 crate]: https://github.com/RustCrypto/elliptic-curves/tree/master/k256","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2329311000\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12877\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12877/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12877\">#12877</a> - y21:const_host_ice, r=dswij"}},{"before":"4e7f97467a3bd7d5501500cdaecc6c855adea42a","after":"d9ae9367ba7814a380b6501c3ca67dadd3d72641","ref":"refs/heads/master","pushedAt":"2024-06-07T09:33:45.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12897 - lochetti:manual_unwrap_or_default_result, r=dswij\n\nLint `manual_unwrap_or_default` for Result as well\n\nThis PR is modifying the  `manual_unwrap_or_default` to be applied/linted for `Result`s as well. It is part of the fixes desired by https://github.com/rust-lang/rust-clippy/issues/12618\n\nchangelog:[`manual_unwrap_or_default`]: Lint for Result types.","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2339110160\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12897\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12897/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12897\">#12897</a> - lochetti:manual_unwrap_or_default_result, r=dswij"}},{"before":"4e7f97467a3bd7d5501500cdaecc6c855adea42a","after":"d9ae9367ba7814a380b6501c3ca67dadd3d72641","ref":"refs/heads/auto","pushedAt":"2024-06-07T09:24:24.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12897 - lochetti:manual_unwrap_or_default_result, r=dswij\n\nLint `manual_unwrap_or_default` for Result as well\n\nThis PR is modifying the  `manual_unwrap_or_default` to be applied/linted for `Result`s as well. It is part of the fixes desired by https://github.com/rust-lang/rust-clippy/issues/12618\n\nchangelog:[`manual_unwrap_or_default`]: Lint for Result types.","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2339110160\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12897\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12897/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12897\">#12897</a> - lochetti:manual_unwrap_or_default_result, r=dswij"}},{"before":"6cfd4ac9557bf339db1ddf883a06e017e9f1fb64","after":"4e7f97467a3bd7d5501500cdaecc6c855adea42a","ref":"refs/heads/master","pushedAt":"2024-06-06T12:18:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12827 - Alexendoo:lint-groups-priority, r=Jarcho\n\n`lint_groups_priority`: ignore lints & groups at the same level\n\nFixes #12270\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2306496816\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12827\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12827/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12827\">#12827</a> - Alexendoo:lint-groups-priority, r=Jarcho"}},{"before":"6cfd4ac9557bf339db1ddf883a06e017e9f1fb64","after":"4e7f97467a3bd7d5501500cdaecc6c855adea42a","ref":"refs/heads/auto","pushedAt":"2024-06-06T12:09:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12827 - Alexendoo:lint-groups-priority, r=Jarcho\n\n`lint_groups_priority`: ignore lints & groups at the same level\n\nFixes #12270\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2306496816\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12827\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12827/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12827\">#12827</a> - Alexendoo:lint-groups-priority, r=Jarcho"}},{"before":"09f50fd9bf314c9e0194023fa73503f0095f68a5","after":"404affb7bdeee0694bc2b9300c4e7ef53f109a60","ref":"refs/heads/gh-pages","pushedAt":"2024-06-05T20:21:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Manishearth","name":"Manish Goregaokar","path":"/Manishearth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1617736?s=80&v=4"},"commit":{"message":"Automatic deploy to GitHub Pages: 6cfd4ac9557bf339db1ddf883a06e017e9f1fb64","shortMessageHtmlLink":"Automatic deploy to GitHub Pages: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/rust-lang/rust-clippy/commit/6cfd4ac9557bf339db1ddf883a06e017e9f1fb64/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/commit/6cfd4ac9557bf339db1ddf883a06e017e9f1fb64\"><tt>6cfd4ac</tt></a>"}},{"before":"d955d0a41f79962fc2a43b570f7604e0cd5d3c41","after":"6cfd4ac9557bf339db1ddf883a06e017e9f1fb64","ref":"refs/heads/master","pushedAt":"2024-06-05T20:20:15.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #10632 - Alexendoo:needless-maybe-sized, r=Jarcho\n\nAdd `needless_maybe_sized` lint\n\nchangelog: new lint: [`needless_maybe_sized`]\n\nCloses #10600","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1663112404\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/10632\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/10632/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/10632\">#10632</a> - Alexendoo:needless-maybe-sized, r=Jarcho"}},{"before":"d955d0a41f79962fc2a43b570f7604e0cd5d3c41","after":"6cfd4ac9557bf339db1ddf883a06e017e9f1fb64","ref":"refs/heads/auto","pushedAt":"2024-06-05T20:11:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #10632 - Alexendoo:needless-maybe-sized, r=Jarcho\n\nAdd `needless_maybe_sized` lint\n\nchangelog: new lint: [`needless_maybe_sized`]\n\nCloses #10600","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1663112404\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/10632\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/10632/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/10632\">#10632</a> - Alexendoo:needless-maybe-sized, r=Jarcho"}},{"before":"1105e9debef75e7fe3ce6306f8fbaf3bacdad046","after":"d955d0a41f79962fc2a43b570f7604e0cd5d3c41","ref":"refs/heads/master","pushedAt":"2024-06-05T20:10:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12891 - paultag:paultag/fix-lint-description, r=Manishearth\n\nFix grammer for the Safety documentation check\n\nThe original message (\"unsafe function's docs miss `# Safety` section\") reads quite awkwardly. I've changed it to \"unsafe function's docs are missing a `# Safety` section\" to have it read better.\n\n```\nchangelog: [`missing_headers`]: Tweak the grammar in the lint message\n```","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2336544418\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12891\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12891/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12891\">#12891</a> - paultag:paultag/fix-lint-description, r=Manish…"}},{"before":"1105e9debef75e7fe3ce6306f8fbaf3bacdad046","after":"d955d0a41f79962fc2a43b570f7604e0cd5d3c41","ref":"refs/heads/auto","pushedAt":"2024-06-05T20:01:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12891 - paultag:paultag/fix-lint-description, r=Manishearth\n\nFix grammer for the Safety documentation check\n\nThe original message (\"unsafe function's docs miss `# Safety` section\") reads quite awkwardly. I've changed it to \"unsafe function's docs are missing a `# Safety` section\" to have it read better.\n\n```\nchangelog: [`missing_headers`]: Tweak the grammar in the lint message\n```","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2336544418\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12891\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12891/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12891\">#12891</a> - paultag:paultag/fix-lint-description, r=Manish…"}},{"before":"bc00d7b94d637fb7ed4d392f29a5d235ef0a1ffe","after":"1105e9debef75e7fe3ce6306f8fbaf3bacdad046","ref":"refs/heads/master","pushedAt":"2024-06-05T19:56:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12700 - Luv-Ray:overly_complex_bool_expr, r=Jarcho\n\n[`overly_complex_bool_expr`]: Fix trigger wrongly on never type\n\nfixes #12689\n\n---\n\nchangelog: fix [`overly_complex_bool_expr`] triggers wrongly on never type","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2255040147\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12700\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12700/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12700\">#12700</a> - Luv-Ray:overly_complex_bool_expr, r=Jarcho"}},{"before":"bc00d7b94d637fb7ed4d392f29a5d235ef0a1ffe","after":"1105e9debef75e7fe3ce6306f8fbaf3bacdad046","ref":"refs/heads/auto","pushedAt":"2024-06-05T19:47:44.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12700 - Luv-Ray:overly_complex_bool_expr, r=Jarcho\n\n[`overly_complex_bool_expr`]: Fix trigger wrongly on never type\n\nfixes #12689\n\n---\n\nchangelog: fix [`overly_complex_bool_expr`] triggers wrongly on never type","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2255040147\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12700\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12700/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12700\">#12700</a> - Luv-Ray:overly_complex_bool_expr, r=Jarcho"}},{"before":"6b246c6c2ba76d00ae49c3ad9fa445804a0a1cf8","after":"09f50fd9bf314c9e0194023fa73503f0095f68a5","ref":"refs/heads/gh-pages","pushedAt":"2024-06-05T19:20:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Manishearth","name":"Manish Goregaokar","path":"/Manishearth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1617736?s=80&v=4"},"commit":{"message":"Automatic deploy to GitHub Pages: bc00d7b94d637fb7ed4d392f29a5d235ef0a1ffe","shortMessageHtmlLink":"Automatic deploy to GitHub Pages: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/rust-lang/rust-clippy/commit/bc00d7b94d637fb7ed4d392f29a5d235ef0a1ffe/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/commit/bc00d7b94d637fb7ed4d392f29a5d235ef0a1ffe\"><tt>bc00d7b</tt></a>"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX9qZTQA","startCursor":null,"endCursor":null}},"title":"Activity · rust-lang/rust-clippy"}